2017-05-13 31 views
0

我正在學習builder設計模式和智能指針。
所以我想在我的代碼中使用smart_ptr。但是當我使用unique_ptr在main中創建實例並將其傳遞給Contractor對象時,它會引發錯誤。將unique_ptr傳遞給對象拋出錯誤

如果我將unqiue_ptr替換爲承包商類以及main中的shared_ptr。 prog運行良好,但沒有調用析構函數。

下面是我使用unique_ptr時得到的錯誤。

error: call to implicitly-deleted copy constructor of 'std::unique_ptr<HouseBuilder>' 
Contractor *ctr1 = new Contractor(lavishHouseBldr); 

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2621: copy constructor is implicitly deleted because 'unique_ptr<HouseBuilder, std::__1::default_delete<HouseBuilder> >' has a user-declared move constructor 
_LIBCPP_INLINE_VISIBILITY unique_ptr(unique_ptr&& __u) _NOEXCEPT 
          ^
passing argument to parameter 'houseBuilder' here 
Contractor(std::unique_ptr<HouseBuilder>houseBuilder): houseBuilder(std::move(houseBuilder)) 

下面是我的代碼..

/* Concrete class for the HousePlan interface */ 
class House 
{ 
private: 
    std::string window, door, bathroom, floor, kitchen; 
public: 
    void setWindow(string window) 
    { 
     this->window = window; 
    } 
    void setDoor(string door) 
    { 
     this->door = door; 
    } 
    ~House() 
    { 
     cout <<"destructor House called"<<endl; 
    } 
}; 
/* Builder class*/ 
class HouseBuilder 
{ 
public: 
    virtual void buildWindow() = 0; 
    virtual void buildDoor()  = 0; 
    virtual House* getHouse() = 0; 
    virtual ~HouseBuilder() = 0; 
}; 
HouseBuilder::~HouseBuilder() 
{ 
    std::cout <<"Destructor for housebuilder called"; 
} 
class LavishHouse:public HouseBuilder 
{ 
public: 
    LavishHouse() 
    { 
     house.reset(new House()); 
    } 
    ~LavishHouse() 
    { 
     cout <<"Lavish House Destructor callled"<<std::endl; 
    } 
    void buildWindow() 
    { 
    house->setWindow(" French Windows"); 
    } 

    void buildDoor() 
    { 
     house->setDoor(" woodenDoor"); 
    } 
    House* getHouse() 
    { 
     return house.get(); 
    } 
private: 
    std::unique_ptr<House> house; 
}; 
/* The Director. Consturct director*/ 

class Contractor 
{ 
public: 
    Contractor(std::unique_ptr<HouseBuilder>houseBuilder): houseBuilder(std::move(houseBuilder)) 
    { 

    } 
    /* Contractor(HouseBuilder*houseBuilder): houseBuilder(houseBuilder) 
    { 

    }*/ 
    ~Contractor() 
    { 
     cout <<"destruct contractor"<<std::endl; 
    } 

    House *getHouse() 
    { 
     return houseBuilder->getHouse(); 
    } 

    void buildHouse() 
    { 
     houseBuilder->buildWindow(); 
     houseBuilder->buildDoor(); 
    } 
private: 
    std::unique_ptr<HouseBuilder> houseBuilder; 

}; 

/* Example on how to use the Builder design pattern */ 
int main() 
{ 

std::unique_ptr< HouseBuilder> lavishHouseBldr(new LavishHouse()); 
Contractor *ctr1 = new Contractor(lavishHouseBldr); // error!!!!! 

ctr1->buildHouse(); 
House *house1 = ctr1->getHouse(); 
cout<<"Constructed: "<<house1<< std::endl; 
return 0; 
} 

回答

0

lavishHouseBldr是一個左值,它不能移動;您也需要在lavishHouseBldr上申請std::move,即

Contractor *ctr1 = new Contractor(std::move(lavishHouseBldr)); 
+0

謝謝。有用 。但是,再次析構函數不會被調用。 – samprat

+0

「構造:0x7f9a26c025a0」。這行是打印出來的,但我期望析構函數也被調用。 – samprat

+0

@samprat - 他們爲什麼?你從來不會在'ctr1'上調用delete。你的程序只是泄漏。 – StoryTeller