他們是寫這段代碼的更好方法嗎？

Question

我知道這段代碼做了我需要做的工作，但我不禁感到有更多...精煉的方式來獲得相同的結果。請注意，最後幾個輸出僅應顯示如果已經有至少1號（多個）是大於或小於0

//This program will take an unspecified number of 
//integers, determine how many of those integers are 
//positive and how many are negative, and finally 
//compute the total and average of the integers. 


import java.util.Scanner; 

public class exampleWork { 

public static void main(String[] args) { 
    //create a scanner 
    Scanner input = new Scanner(System.in); 

    //create a variable to hold the positive integers 
    int pos = 0; 

    //create a variable to hold the negative integers 
    int neg = 0; 

    //create a variable to hold the total number of entries 
    int total = 0; 

    //create a variable to hold the average 
    float avg = 0; 

    //create a counter variable 
    int count = 0; 

    //prompt user to enter integer 
    System.out.println("Enter an integer, the input ends if it is 0: "); 
    int usrInput = input.nextInt(); 

     //determine if the number is positive, negative, 
     //or zero, and either place in relative variables, 
     //or end the loop. 
    if (usrInput == 0) 
     System.out.print("Only zero was entered"); 

    while (usrInput != 0) { 

      if (usrInput > 0){ 
      pos++; 
      total += usrInput; 
      count++; 
      System.out.println("Enter an integer, the input ends if it is 0: "); 
      usrInput = input.nextInt(); 


      } if (usrInput < 0){ 
      neg++; 
      total += usrInput; 
      count++; 
      System.out.println("Enter an integer, the input ends if it is 0: "); 
      usrInput = input.nextInt(); 


      } 

     } 
    if (count > 0){ 
    avg = (total/count); 
    System.out.println("The number of positives is " + pos); 
    System.out.println("The number of negatives is " + neg); 
    System.out.println("The total is " + total); 
    System.out.println("The average is " + avg); 
    } 

}

}

Answer 1

您複製的兩個o內部代碼f你的主要ifs。這部分將它們提取出來並清理一些。

while (usrInput != 0) { 
    if (usrInput > 0) 
     pos++; 
    else 
     neg++; 

    total += usrInput; 
    count++; 
    System.out.println("Enter an integer, the input ends if it is 0: "); 
    usrInput = input.nextInt(); 
} 

[編輯，而我只是做一樣XD 6，但現在我做]在一些其他注意事項：

• 你並不需要保持運行的「數」，因爲它可以在主while循環之後通過添加（pos + neg）來計算。
• 您正在添加額外的代碼來執行第一次試用。
• 你正在平均2個整數，這是一個整數，而不是一個浮點數。
• 你不需要明確地存儲平均值，因爲它只被使用一次。

這是減輕

import java.util.Scanner; 

public class exampleWork { 
    public static void main(String[] args) { 
     //create a scanner 
     Scanner input = new Scanner(System.in); 

     //create a variable to hold the positive integers 
     int pos = 0; 

     //create a variable to hold the negative integers 
     int neg = 0; 

     //create a variable to hold the total number of entries 
     int total = 0; 

     while(true) { 
      System.out.println("Enter an integer, the input ends if it is 0: "); 
      usrInput = input.nextInt(); 
      if(usrInput==0) 
       break; 

      if (usrInput > 0) 
       pos++; 
      else 
       neg++; 

      total += usrInput; 
     } 

     int count=pos+neg; 
     if (count > 0){ 
      System.out.println("The number of positives is " + pos); 
      System.out.println("The number of negatives is " + neg); 
      System.out.println("The total is " + total); 
      System.out.println("The average is " + ((float)total/count)); //Not sure if this typecast is correct, it's been a long time since i have worked in java 
     } 
    } 
} 

Answer 2

注意，兩大部分if語句是相同的，因此它們可以在if。外面被提取，而不是重複：

while (usrInput != 0) { 
    total += usrInput; 
    count++; 

    if (usrInput > 0) { 
     pos++; 
    } else { 
     neg++ 
    } 

    System.out.println("Enter an integer, the input ends if it is 0: "); 
    usrInput = input.nextInt(); 
}