2016-08-02 105 views
0

我有一個recyclerView,它讓我崩潰:Android - RecyclerView NullPointerException getItemCount?

enter image description here

這裏是我的StartActivity:

public class StartActivity extends AppCompatActivity { 

    TextView txtTest; 
    private ProgressDialog pDialog; 
    // These tags will be used to cancel the requests 
    private String tag_json_obj = "jobj_req", tag_json_arry = "jarray_req"; 

    private RecyclerView.Adapter mAdapter; 
    RecyclerView UserCode_Recycler; 
    private LinearLayoutManager mLayoutManager; 


    List<Marketing_Code> userCodeList; 

    @Override 
    protected void onCreate(Bundle savedInstanceState) { 
     super.onCreate(savedInstanceState); 
     setContentView(R.layout.activity_start); 
     txtTest = (TextView) findViewById(R.id.txtTest); 
     UserCode_Recycler = (RecyclerView) findViewById(R.id.UserCode_Recycler); 
     pDialog = new ProgressDialog(this); 
     pDialog.setMessage("Loading..."); 
     pDialog.setCancelable(false); 

     Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar); 
     setSupportActionBar(toolbar); 

     FloatingActionButton fab = (FloatingActionButton) findViewById(R.id.fab); 
     if (fab != null) { 
      fab.setOnClickListener(new View.OnClickListener() { 
       @Override 
       public void onClick(View view) { 
        Snackbar.make(view, "Replace with your own action", Snackbar.LENGTH_LONG) 
          .setAction("Action", null).show(); 
       } 
      }); 
     } 

     makeJsonArryReq(); 

     userCodeList = new ArrayList<>(); 
     // create an Object for Adapter 
     mAdapter = new UserCodeList_Adapter(userCodeList, StartActivity.this); 
     // set the adapter object to the Recyclerview 
     UserCode_Recycler.setAdapter(mAdapter); 

     mAdapter.notifyDataSetChanged(); 


     UserCode_Recycler.setHasFixedSize(true); 

     mLayoutManager = new LinearLayoutManager(this); 
     // use a linear layout manager 
     UserCode_Recycler.setLayoutManager(mLayoutManager); 

    } 

    private void showProgressDialog() { 
     if (!pDialog.isShowing()) 
      pDialog.show(); 
    } 

    private void hideProgressDialog() { 
     if (pDialog.isShowing()) 
      pDialog.hide(); 
    } 


    /** 
    * Making json array request 
    */ 
    private void makeJsonArryReq() { 
     showProgressDialog(); 
     JsonArrayRequest req = new JsonArrayRequest(Const.Marketing_List, 
       new Response.Listener<JSONArray>() { 
        @Override 
        public void onResponse(JSONArray response) { 
         Log.d("MYData", response.toString()); 
         userCodeList = MarketingCode_JSONParser.parseFeed(response.toString()); 
         /* // create an Object for Adapter 
         mAdapter = new UserCodeList_Adapter(userCodeList, StartActivity.this); 
         // set the adapter object to the Recyclerview 
         Search_Recycler.setAdapter(mAdapter); 
         mAdapter.notifyDataSetChanged(); 
         //txtTest.setText(response.toString());*/ 
         mAdapter.notifyDataSetChanged(); 
         hideProgressDialog(); 
        } 
       }, new Response.ErrorListener() { 
      @Override 
      public void onErrorResponse(VolleyError error) { 
       VolleyLog.d("Custom Log Error", "Error: " + error.getMessage()); 
       hideProgressDialog(); 
      } 
     }); 

     // Adding request to request queue 
     AppController.getInstance().addToRequestQueue(req, tag_json_arry); 
     // Cancelling request 
     // ApplicationController.getInstance().getRequestQueue().cancelAll(tag_json_arry); 
    } 


    @Override 
    public boolean onCreateOptionsMenu(Menu menu) { 
     // Inflate the menu; this adds items to the action bar if it is present. 
     getMenuInflater().inflate(R.menu.menu_main, menu); 
     return true; 
    } 

    @Override 
    public boolean onOptionsItemSelected(MenuItem item) { 
     // Handle action bar item clicks here. The action bar will 
     // automatically handle clicks on the Home/Up button, so long 
     // as you specify a parent activity in AndroidManifest.xml. 
     int id = item.getItemId(); 

     //noinspection SimplifiableIfStatement 
     if (id == R.id.action_settings) { 
      return true; 
     } 

     return super.onOptionsItemSelected(item); 
    } 
} 

而且我的適配器:

public class UserCodeList_Adapter extends RecyclerView.Adapter<UserCodeList_Adapter.ViewHolder> { 

    private List<Marketing_Code> ucList; 
    public static Activity activity; 
    public UserCodeList_Adapter(List<Marketing_Code> userCodeList, Activity activity) { 
     this.ucList = userCodeList; 
     this.activity = activity; 
    } 
    @Override 
    public UserCodeList_Adapter.ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) { 
     // create a new view 
     View itemLayoutView = LayoutInflater.from(parent.getContext()).inflate(R.layout.listmarketing_cardview, null); 

     // create ViewHolder 
     ViewHolder viewHolder = new ViewHolder(itemLayoutView); 
     return viewHolder; 
    } 

    @Override 
    public void onBindViewHolder(UserCodeList_Adapter.ViewHolder viewHolder, int position) { 
     String userCode =String.valueOf(ucList.get(position).getMarketCode()); 
     viewHolder.txtUserID.setText(userCode); 
    } 

    @Override 
    public int getItemCount() { 
     return ucList.size(); 
     //return ucList == null ? 0 : ucList.size(); 
    } 

    public static class ViewHolder extends RecyclerView.ViewHolder { 

     public TextView txtUserID; 

     public Marketing_Code items; 

     public ViewHolder(View itemLayoutView) { 
      super(itemLayoutView); 

      txtUserID = (TextView) itemLayoutView.findViewById(R.id.txtUserID); 
      // Onclick event for the row to show the data in toast 
      itemLayoutView.setOnClickListener(new View.OnClickListener() { 

       @Override 
       public void onClick(View v) { 
       } 
      }); 

     } 

    } 
} 

回答

3

您尚未初始化userCodeList

看到您的代碼,您將適配器基於該列表,但尚未初始化。因此,當適配器試圖瞭解您的列表中有多少項目時,會拋出NullPointerException

您的userCodeList聲明更改爲一個象下面這樣:

List<Marketing_Code> userCodeList = new ArrayList<>(); 

看到你更新的問題,你似乎從一個JSON響應基礎數據。如果是這樣的話,你現在正在做的是差不多是正確的。

觀察這個稍加修改你的代碼片段:

private void makeJsonArryReq() { 
    showProgressDialog(); 
    JsonArrayRequest req = new JsonArrayRequest(Const.Marketing_List, 
      new Response.Listener<JSONArray>() { 
       @Override 
       public void onResponse(JSONArray response) { 
        Log.d("MYData", response.toString()); 
        /* YOUR OLD CODE -> */ // userCodeList = MarketingCode_JSONParser.parseFeed(response.toString()); 
        /* HOW IT SHOULD'VE BEEN */ userCodeList.addAll(MarketingCode_JSONParser.parseFeed(response.toString())); 
        mAdapter.notifyDataSetChanged(); 
        hideProgressDialog(); 
       } 
      }, new Response.ErrorListener() { 
     @Override 
     public void onErrorResponse(VolleyError error) { 
      VolleyLog.d("Custom Log Error", "Error: " + error.getMessage()); 
      hideProgressDialog(); 
     } 
    }); 

// ... 

看看上面的代碼中的註釋部分。這樣做應該可以解決您的問題並使數據在屏幕上可見。

+0

不要誤會我的任何崩潰了,但我的列表是空的? –

+0

這是真的嗎? String userCode = String.valueOf(ucList.get(position).getMarketCode()); –

+0

恩,這是..你應該在後面的過程中填寫這個'List'。只要調用'adapter.notifyDataSetChaged()',你應該看到你的項目顯示在屏幕上。 – ridsatrio

1

兩種方式來處理這個問題:

  1. 您需要檢查,如果該列表爲空,要求檢查其大小

    public int getItemCount() { 
        if(ucList == null) 
         return 0; 
        return ucList.size(); 
    } 
    
  2. 另外,之前,這是推薦的方法來這個問題,是在開始時將它初始化爲空列表,或者確保它在被關聯的適配器訪問之前始終被初始化。

    List<Marketing_Code> userCodeList = new ArrayList<>();

希望這有助於。

+0

第一種方式可能會起作用。但是不能保證它能夠阻止'null' List導致的隨後的崩潰。適配器嚴重依賴於它們的'List',所以它不應該首先是'null'。 – ridsatrio

+0

同意。更新回答點2以在訪問之前通過初始化陳述推薦的方法 – akdsouza

0

我想你需要使用replaceAll函數作爲列表,而不是直接等同。 這裏

userCodeList = MarketingCode_JSONParser.parseFeed(response.toString()); 

嘗試檢查,如果userCodeList包含initialzing適配器之前的任何數據。

0

請執行下列操作,並嘗試

// create an Object for Adapter   
    userCodeList = new ArrayList<>(); 
    mAdapter = new UserCodeList_Adapter(userCodeList, StartActivity.this);