重構if-else語句檢查不同的文件擴展名

Question

我有這段代碼，我覺得可以清理（我可能是錯的），但我想看看是否有人有一個建議，我可以改變這是「更好」

string getExt = Path.GetExtension(DocumentUNCPath.Text); 
     var convertFileId = Guid.NewGuid(); 
     var convertFilePath = @"c:\temp\" + convertFileId + ".pdf"; 


     if (getExt == ".doc" || getExt == ".docx" || getExt == ".txt" || getExt == ".rtf") 
     { 
      WordToPdf(convertFilePath); 

     } 
     else if (getExt == ".xlsx" || getExt == ".xls") 
     { 
      ExcelToPdf(convertFilePath); 
     } 
     else if (getExt == ".jpg" || getExt == ".png" || getExt == ".jpeg" || getExt == ".JPG" || getExt == ".PNG") 
     { 
      ImgToPDF(convertFilePath); 
     } 

Answer 1

以下可能最初是更多的代碼，但可以更好地擴展。

之外的方法：

public static readonly List<string> WorkExtensions = new List<string> { ".doc", ".docx", ".txt", ".trf" }; 
    public static readonly List<string> ExcelExtensions = new List<string> { ".xlsx", ".xls" }; 
    public static readonly List<string> ImageExtensions = new List<string> { ".jpg", ".png", ".jpeg" }; 

裏面的方法：

string getExt = Path.GetExtension(DocumentUNCPath.Text); 
    var convertFileId = Guid.NewGuid(); 
    var convertFilePath = @"c:\temp\" + convertFileId + ".pdf"; 

    getExt = getExt.ToLower(); 

    if (WorkExtensions.Contains(getExt)) 
    { 
     WordToPdf(convertFilePath) 
    } 
    else if (ExcelExtensions.Contains(getExt)) 
    { 
     ExcelToPdf(convertFilePath); 
    } 
    else if (ImageExtensions.Contains(getExt)) 
    { 
     ImgToPdf(convertFilePath); 
    } 

Answer 2

地圖擴展處理的是這樣的情況下，標準的方法：

// populate with { ".doc", WordToPdf } and similar pairs 
Dictionary<string, Action<string> > handlers = ... 


// find and call handler by extension 
// (use TryGetValue to check for existence if needed) 
handlers[getExt](convertFilePath); 

Answer 3

你可以做這樣的事情

switch (getExt.ToUpper()) 
    {  
     case "JPG":  
     case "PNG": 
.... 

Answer 4

如果您正在尋找extensiblity，你可以conisder是這樣的：

public struct Converter { 
    public string   Extension; 
    public Action<string> ConvertAction; 
} 

public static class Extensions { 
    static Action<string> WordToPdf = (s) => {;}; 
    static Action<string> ExcelToPdf = (s) => {;}; 
    static Action<string> ImgToPdf = (s) => {;}; 

    public static IEnumerable<Converter> Converters = new List<Converter> { 
    new Converter {Extension = ".doc", ConvertAction = WordToPdf}, 
    new Converter {Extension = ".docx", ConvertAction = WordToPdf}, 
    new Converter {Extension = ".txt", ConvertAction = WordToPdf}, 
    new Converter {Extension = ".rtf", ConvertAction = WordToPdf}, 

    new Converter {Extension = ".xls", ConvertAction = ExcelToPdf}, 
    new Converter {Extension = ".xlsx", ConvertAction = ExcelToPdf}, 

    new Converter {Extension = ".jpg", ConvertAction = ImgToPdf}, 
    new Converter {Extension = ".png", ConvertAction = ImgToPdf}, 
    new Converter {Extension = ".jpeg", ConvertAction = ImgToPdf}, 
    new Converter {Extension = ".doc", ConvertAction = ImgToPdf} 
    }; 

    public void RunIt(string extension, string convertFilePath) { 
    extension = extension.ToLower(); 
    var action = (from a in Converters 
        where a.Extension.Equals(extension) 
        select a.ConvertAction).First(); 
    if (action != null) action(convertFilePath); 
    } 
} 

Answer 5

我覺得Dictionary<string, Action<string>>以上答案是最優雅的答案，但爲了完整起見，這裏有一個解決方案通過串擴展：

public static class StringExt 
{ 
    public static bool MatchesAnyOf(this string text, params string[] targets) 
    { 
     return targets.Any(target => string.Compare(text, target, StringComparison.OrdinalIgnoreCase) == 0); 
    } 
} 

然後，你可以寫這樣的代碼：

if (getExt.MatchesAnyOf(".doc", ".doxc", ".txt", ".rtf")) 
{ 
    WordToPdf(convertFilePath); 
} 
else if (getExt.MatchesAnyOf(".xlsx", ".xls")) 
{ 
    ExcelToPdf(convertFilePath); 
} 
else if (getExt.MatchesAnyOf(".jpg", ".png", ".jpeg", ".JPG", ".PNG") 
{ 
    ImgToPDF(convertFilePath); 
} 

此實現忽略大小寫和文化，這是適當的文件名，但將不適合用於一般用途 - 所以真正的代碼可能會提供指定文化和比較類型的重載。