有沒有辦法將這3個查詢合併爲一個

Question

我有這樣的代碼，它確實不是最漂亮和最有效的代碼。代碼的作品，但我覺得有辦法避免所有的循環，並結合這些查詢，並可能創建一個數組。我只是想知道如果任何人有關於如何提高這個

$sql = "SELECT p.image, group_concat(pi.image) as additional_images 
FROM product as p 
JOIN product_image as pi on pi.product_id=p.product_id 
WHERE p.product_id = '{$product['standard']['product_id']}'"; 
$result = mysql_query($sql); 
$images_before = mysql_fetch_assoc($result); 
$images = array(); 
if($images_before['additional_images'] != ""){ 
$images = explode(",", $images_before['additional_images']); 
} 
array_push($images, $images_before['image']); 
$sql2 = "SELECT p.image, group_concat(pi.image) as additional_images 
FROM product as p 
JOIN product_image as pi on pi.product_id=p.product_id 
WHERE p.product_id = '{$product['professional']['product_id']}'"; 
$result2 = mysql_query($sql2); 
$images_before2 = mysql_fetch_assoc($result2); 
$images2 = array(); 
if($images_before2['additional_images'] != ""){ 
$images2 = explode(",", $images_before2['additional_images']); 
} 
array_push($images2, $images_before2['image']); 
$sql3 = "SELECT p.image, group_concat(pi.image) as additional_images 
FROM product as p 
JOIN product_image as pi on pi.product_id=p.product_id 
WHERE p.product_id = '{$product['premium']['product_id']}'"; 
$result3 = mysql_query($sql3); 
$images_before3 = mysql_fetch_assoc($result3); 
$images3 = array(); 
if($images_before3['additional_images'] != ""){ 
$images3 = explode(",", $images_before3['additional_images']); 
} 
array_push($images3, $images_before3['image']); 
$counter = 0; 
foreach($images as $image) { 
     if ($counter == 0) { 
      echo "<a id='show_{$product['standard']['product_id']}' style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['standard']['product_id']}]'></a>"; 
       $counter++; 
     }else{ 
     echo "<a style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['standard']['product_id']}]'></a>"; 
      $counter++; 
     } 
} 

$counter2 = 0; 
    foreach($images2 as $image) { 
     if ($counter2 == 0) { 
      echo "<a id='show_{$product['professional']['product_id']}' style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['professional']['product_id']}]'></a>"; 
        $counter2++; 
     }else{ 
      echo "<a style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['professional']['product_id']}]'></a>"; 
       $counter2++; 
      } 
} 
$counter3 = 0; 
    foreach($images3 as $image) { 
      if ($counter3 == 0) { 
       echo "<a id='show_{$product['premium']['product_id']}' style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['premium']['product_id']}]'></a>"; 
         $counter3++; 
      }else{ 
      echo "<a style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['premium']['product_id']}]'></a>"; 
        $counter3++; 
       } 
    } 
?> 

Answer 1

而不是使用where p.product_id = <value>的，使用WHERE IN語法任何指針：

$sql = "SELECT ... 
WHERE p.product_id IN (
    {$product['standard']['product_id']}, 
    {$product['professional']['product_id']}, 
    {$product['premium']['product_id']} 
)"; 

Answer 2

你的代碼是非常糟糕的本身。您需要學習應用程序體系結構和設計以及語言本身。

這裏是一個很好的文章開始：http://symfony.com/doc/current/book/from_flat_php_to_symfony2.html

至於對代碼提示：

不要使用group_concat和explode。更好地做到兩個查詢不JOIN：

1. 使用IN得到的所有圖像（）
2. 得到使用IN（）
3. 循環中的所有additional_images在additional_images並將其綁定到的圖像在PHP中環

Answer 3

$sql = " 
    SELECT p.product_id, p.image, group_concat(pi.image) as additional_images 
    FROM product as p 
     JOIN product_image as pi on pi.product_id=p.product_id 
    WHERE p.product_id IN ({$product['standard']['product_id']}, {$product['professional']['product_id']}, {$product['premium']['product_id']})"; 

$result = mysql_query($sql); 
while($product_result = mysql_fetch_assoc($result)) { 
    $images = explode(',', $product_result['additional_images']); 
    $first = true; 
    foreach($images as $image) { 
     if($first) { 
      echo "<a id='show_{$product_result['product_id']}' style='display:none;' href='http://posnation.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product_result['product_id']}]'></a>"; 
      $first = false; 
     } 
     else { 
      echo "<a style='display:none;' href='http://posnation.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['standard']['product_id']}]'></a>"; 
     } 
    } 
}