工作LINQ查詢產生錯誤「CA1505：Microsoft.Maintainability」

Question

我有一個LINQ查詢工作得很好，但是當了StyleCop是在產生以下錯誤的項目運行：「CA1505：Microsoft.Maintainability：重寫或重構該類型的方法來增加其可維護性指數（MI）「。我測試過除去部分查詢，發現修復了錯誤。問題似乎是查詢太長，所以我正在尋找一種方法來縮短它以消除CA1505錯誤。這裏面臨的挑戰是數據駐留在5個主表中，與此相當的sql基本上是5個union的所有語句。有什麼建議麼？

public List<ExpiringItemModel> GetByDaysToExpire(int days) 
    { 
     var int1 = days - 30; 
     var int2 = days - 16; 
     var int3 = days - 0; 

     var query = (
      from outlet in _modelContext.Outlets 
      join outletcommunicationmethod in _modelContext.OutletCommunicationMethods on 
       new { Id = outlet.Id } 
       equals new { Id = outletcommunicationmethod.OutletId } 
      join outletcarpermitagent in _modelContext.outletcarpermitagents on 
       new { Id = outlet.Id } equals 
       new { Id = outletcarpermitagent.OutletId } 
      join outlettype in _modelContext.OutletTypes on 
       new { OutletTypeId = outletcarpermitagent.OutletTypeId } equals 
       new { OutletTypeId = outlettype.Id } 
      where 
       (outletcommunicationmethod.CommunicationMethodId == 1 
       && 
       SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
             outletcarpermitagent.BondExpirationDate) > 0) && 

       (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
             outletcarpermitagent.BondExpirationDate) == days || 
       (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
             outletcarpermitagent.BondExpirationDate) == 30) || 
       (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
             outletcarpermitagent.BondExpirationDate) == 14)) 

      select new ExpiringItemModel 
      { 
       Id = (Int32)outletcarpermitagent.Id, 
       AgentType = outlettype.Value, 
       Email = outletcommunicationmethod.Value, 
       BondExpirationDate = (DateTime)outletcarpermitagent.BondExpirationDate 
      } 
      ).Concat 
      (
       from outlet_1 in _modelContext.Outlets 
       join outletcommunicationmethod_1 in _modelContext.OutletCommunicationMethods on 
        new { Id = outlet_1.Id } equals new { Id = outletcommunicationmethod_1.OutletId } 
       join outlettruckpermitagent in _modelContext.outlettruckpermitagents on 
        new { Id = outlet_1.Id } equals new { Id = outlettruckpermitagent.OutletId } 
       join outlettype_1 in _modelContext.OutletTypes on 
        new { OutletTypeId = outlettruckpermitagent.OutletTypeId } equals 
        new { OutletTypeId = outlettype_1.Id } 
       where 
        (outletcommunicationmethod_1.CommunicationMethodId == 1 
        && 
        SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outlettruckpermitagent.BondExpirationDate) > 0) && 

        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outlettruckpermitagent.BondExpirationDate) == days || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outlettruckpermitagent.BondExpirationDate) == 30) || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outlettruckpermitagent.BondExpirationDate) == 14)) 

       select new ExpiringItemModel 
       { 
        Id = (Int32)outlettruckpermitagent.Id, 
        AgentType = outlettype_1.Value, 
        Email = outletcommunicationmethod_1.Value, 
        BondExpirationDate = (DateTime)outlettruckpermitagent.BondExpirationDate 
       } 
      ).Concat 
      (
       from outlet_2 in _modelContext.Outlets 
       join outletcommunicationmethod_2 in _modelContext.OutletCommunicationMethods on 
        new { Id = outlet_2.Id } equals new { Id = outletcommunicationmethod_2.OutletId } 
       join outletcyclepermitagent in _modelContext.outletcyclepermitagents on new { Id = outlet_2.Id } equals 
        new { Id = outletcyclepermitagent.OutletId } 
       join outlettype_2 in _modelContext.OutletTypes on new { OutletTypeId = outletcyclepermitagent.OutletTypeId } 
        equals new { OutletTypeId = outlettype_2.Id } 
       where 
        (outletcommunicationmethod_2.CommunicationMethodId == 1 
        && 
        SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletcyclepermitagent.BondExpirationDate) > 0) && 

        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletcyclepermitagent.BondExpirationDate) == days || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletcyclepermitagent.BondExpirationDate) == 30) || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletcyclepermitagent.BondExpirationDate) == 14)) 

       select new ExpiringItemModel 
       { 
        Id = (Int32)outletcyclepermitagent.Id, 
        AgentType = outlettype_2.Value, 
        Email = outletcommunicationmethod_2.Value, 
        BondExpirationDate = (DateTime)outletcyclepermitagent.BondExpirationDate 
       } 
       ).Concat 
       (
       from outlet_3 in _modelContext.Outlets 
       join outletcommunicationmethod_3 in _modelContext.OutletCommunicationMethods on 
        new { Id = outlet_3.Id } equals new { Id = outletcommunicationmethod_3.OutletId } 
       join outletscooteragent in _modelContext.outletscooteragentAgents on 
        new { Id = outlet_3.Id } equals 
        new { Id = outletscooteragent.OutletId } 
       join outlettype_3 in _modelContext.OutletTypes on 
        new { OutletTypeId = outletscooteragent.OutletTypeId } 
        equals new { OutletTypeId = outlettype_3.Id } 
       where 
        (outletcommunicationmethod_3.CommunicationMethodId == 1 
        && 
        SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletscooteragent.BondExpirationDate) > 0) && 

        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletscooteragent.BondExpirationDate) == days || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletscooteragent.BondExpirationDate) == 30) || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletscooteragent.BondExpirationDate) == 14)) 

       select new ExpiringItemModel 
       { 
        Id = (Int32)outletscooteragent.Id, 
        AgentType = outlettype_3.Value, 
        Email = outletcommunicationmethod_3.Value, 
        BondExpirationDate = (DateTime)outletscooteragent.BondExpirationDate 
       } 
       ).Concat 
       (
       from outlet_4 in _modelContext.Outlets 
       join outletcommunicationmethod_4 in _modelContext.OutletCommunicationMethods on 
        new { Id = outlet_4.Id } equals new { Id = outletcommunicationmethod_4.OutletId } 
       join outletoffroadagent in _modelContext.outletoffroadagentAgents on new { Id = outlet_4.Id } equals 
        new { Id = outletoffroadagent.OutletId } 
       join outlettype_4 in _modelContext.OutletTypes on new { OutletTypeId = outletoffroadagent.OutletTypeId } 
        equals new { OutletTypeId = outlettype_4.Id } 
       where 
        (outletcommunicationmethod_4.CommunicationMethodId == 1 
        && 
        SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletoffroadagent.BondExpirationDate) > 0) && 

        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletoffroadagent.BondExpirationDate) == days || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletoffroadagent.BondExpirationDate) == 30) || 
        (SqlFunctions.DateDiff("day", SqlFunctions.GetDate(), 
              outletoffroadagent.BondExpirationDate) == 14)) 

       select new ExpiringItemModel 
       { 
        Id = (Int32)outletoffroadagent.Id, 
        AgentType = outlettype_4.Value, 
        Email = outletcommunicationmethod_4.Value, 
        BondExpirationDate = (DateTime)outletoffroadagent.BondExpirationDate 
       } 
       ); 

      return query.ToList(); 
     } 

Answer 1

您可以將每個Concat分成它自己的查詢。

例如

var query1 = from outlet in _modelContext.Outlets 
       ...; 

var query2 = from outlet in _modelContext.Outlets 
       ...; 


var fullquery = query1.Concat(query2).Concat(...);