Ruby不增加數字

Question

我編寫代碼來查找Collat​​z猜想下需要的數字的操作數。但是，我的操作變量似乎並沒有增加。

我的代碼是：

puts "Please input a number" 
number = gets.chomp 
number = number.to_i 
operations = 0 
modulo = number % 2 
while number =! 1 
    if modulo == 0 
     number = number/2 
     operations = operations + 1 
    elsif modulo =! 0 && number =! 1 
     number = number * 3 
     number = number += 1 
     operations = operations + 2 
    else 
     puts "Uh oh, something went wrong." 
    end 
end 
puts "It took #{operations} operations!" 

我上https://www.repl.it運行此代碼。

Answer 1

首先，它是elsif;不是elseif（我編輯了你的問題）。不等號是!=;不是=!。但是這有一個不同的含義。 （即：number =! 1表示number = !1）

在第12行中，number = number += 1是什麼？我想你的意思是number += 1或number = number + 1。

現在，代碼有效。 :)

這是最終版本。

puts "Please input a number" 
number = gets.chomp 
number = number.to_i 
operations = 0 
modulo = number % 2 
while number != 1 
    if modulo == 0 
     number = number/2 
     operations = operations + 1 
    elsif modulo != 0 && number != 1 
     number = number * 3 
     number = number + 1 
     operations = operations + 2 
    else 
     puts "Uh oh, something went wrong." 
    end 
end 
puts "It took #{operations} operations!" 

使用方法：

Please input a number 
256 
It took 8 operations! 

的最佳解決方案的功能：

def collatz(n) 
    if n % 2 == 0 
     return n/2 
    else 
     return 3*n + 1 
    end 
end 
def chainLength(num) 
    count = 1 
    while num > 1 
     count += 1 
     num = collatz(num) 
    end 
    return count 
end 

puts "Please input a number" 
number = gets.chomp 
number = number.to_i 
operations = chainLength(number) 
puts "It took #{operations} operations!" 

如果需要更高的性能，瞭解動態規劃和記憶化技術。