2010-09-15 48 views
1

這裏的碰撞是一個相當大的C++程序的一個片段:Desctuction對象導致程序

map<int, int>::iterator class_it = docsCountPerClass.begin(); 
for(;class_it != docsCountPerClass.end(); class_it++) { 
    cout << "classid: " << class_it->first << '\n'; 
    vector<term_importance> ti; 
    ti.reserve(termids.size()); 
    vector<int>::iterator term_it = termids.begin(); 
    for(;(term_it != termids.end()); term_it++) { 
     term_importance tmp; 
     tmp.termid = *term_it; 
     tmp.importnaceMeasure = chiSquareTest(*term_it, class_it->first); 
     ti.push_back(tmp); 
    } 
    if(ti.size() != 0) 
     std::sort(ti.begin(), ti.end()); 
    for(int i = 0; i < ti.size(); i++) 
     cout << (ti.at(i)).termid << " -- " << (ti.at(i)).importnaceMeasure << '\n'; 
    int ti_size_tmp = ti.size(); 
    for(int i = 0; i < std::min(maxFeaturesPerClass, int(ti.size())); i++) { 
     cout << "* index access: " << ti_size_tmp - 1 - i << '\n'; 
     usefulTerms[class_it->first].push_back((ti.at(ti_size_tmp - 1 - i)).termid); 
    } 

的問題,我當面向循環完成循環,並返回矢量TI應該銷燬。它確實會在清理內部對象時崩潰,並報告它嘗試在無效指針上調用free()。​​我無法使用更簡單的代碼重現問題。這裏是回溯用gdb:

#0 0x0012d422 in __kernel_vsyscall() 
#1 0x00341651 in *__GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 
#2 0x00344a82 in *__GI_abort() at abort.c:92 
#3 0x0037849d in __libc_message (do_abort=2, fmt=0x44cf98 "*** glibc detected *** %s: %s: 0x%s ***\n") at ../sysdeps/unix/sysv/linux/libc_fatal.c:189 
#4 0x00382591 in malloc_printerr (action=<value optimized out>, str=0x6 <Address 0x6 out of bounds>, ptr=0x81dc5e0) at malloc.c:6264 
#5 0x00383de8 in _int_free (av=<value optimized out>, p=<value optimized out>) at malloc.c:4792 
#6 0x00386ecd in *__GI___libc_free (mem=0x81dc5e0) at malloc.c:3738 
#7 0x00297741 in operator delete(void*)() from /usr/lib/libstdc++.so.6 
#8 0x08054377 in __gnu_cxx::new_allocator<NaiveBayesClassifier::term_importance>::deallocate (this=0xbffff194, __p=0x81dc5e0) 
    at /usr/include/c++/4.4/ext/new_allocator.h:95 
#9 0x080522db in std::_Vector_base<NaiveBayesClassifier::term_importance, std::allocator<NaiveBayesClassifier::term_importance> >::_M_deallocate (this=0xbffff194, 
    __p=0x81dc5e0, __n=4433) at /usr/include/c++/4.4/bits/stl_vector.h:146 
#10 0x0805219e in ~_Vector_base (this=0xbffff194, __in_chrg=<value optimized out>) at /usr/include/c++/4.4/bits/stl_vector.h:132 
#11 0x08050139 in ~vector (this=0xbffff194, __in_chrg=<value optimized out>) at /usr/include/c++/4.4/bits/stl_vector.h:313 
#12 0x0804d32d in NaiveBayesClassifier::buildModel (this=0xbffff28c, maxFeaturesPerClass=100) at NaiveBayesClassifier.cpp:106 
#13 0x0805c357 in main (argc=2, argv=0xbffff3d4) at nbClassifyMain.cpp:15 

編輯1: NaiveBayesClassifier.cpp:http://paste.bradleygill.com/index.php?paste_id=49445 NaiveBayesClassifier.h:http://paste.bradleygill.com/index.php?paste_id=49446

編輯2: 我註釋掉std::sort(ti.begin(), ti.end());,發現錯誤的是不見了。現在我很困惑std :: sort()是如何工作的。

+1

這裏有很多代碼是不可見的,使得這個例子顯然不是錯誤的。嘗試提供使用functinos的代碼和當前函數的參數...給出更多的上下文。 – Klaim 2010-09-15 18:35:18

+0

請清理代碼一點..讓我想回答這個問題。 – jrharshath 2010-09-15 18:37:57

+0

問題可能出現在「term_importance」類中。它的拷貝構造是否正確? – UncleBens 2010-09-15 18:39:26

回答

2

該堆棧跟蹤的第9行使我相信所提到的向量正在執行雙重刪除。我會研究放入該向量中的類,並確保它們遵循三條規則,或者至少在刪除它們之後將指針設置爲null。

+1

這是有問題的類,通過它的外觀:NaiveBayesClassifier :: term_importance – 2010-09-15 18:55:41

1

valgrind下運行你的程序,它應該可以幫助你診斷什麼是錯的。