1. 首頁
  2. 問答
  3. 這段代碼可以更清潔嗎？它看起來是正確的狀態？

這段代碼可以更清潔嗎？它看起來是正確的狀態？

2011-10-09 74 views
0

我有這樣的代碼來拉數據庫中的數據並將數據插入到4列之一，這段代碼可以更清潔嗎？它看起來是正確的狀態？

我花了一整天搜索，只是不能似乎找到了如何做到這一點..

理想情況下，我想選擇所有的數據庫，然後在獲取數組有1列ID - 反響，那麼大人了下一列等。

<?php 


      echo '<div class="column grid_3 clearfix" id="column0" >'; 
      echo '&nbsp;'; 
      $user_sites_0=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='0' ORDER BY sort_no"); 

      if(!$user_sites_0) { 
       echo 'No sites added, please <a class="addsite" href="#">add one now</a>'; 
      } 
      else { 

       while($user_site_0=mysqli_fetch_array($user_sites_0)) 
       { 
        $id = stripslashes($user_site_0['id']); 
        $site_name = stripslashes($user_site_0['site_name']); 
        $site_address = stripslashes($user_site_0['site_address']); 
        $site_desc = stripslashes($user_site_0['site_desc']); 
        $site_category = stripslashes($user_site_0['site_category']); 
        $getImage = 'http://immediatenet.com/t/s?Size=1024x768&URL='.$site_address; 
        echo '<div class="dragbox" id="item'.$id.'">'; 
        echo '<h2 class="h2handle">'.$site_name.' <span class="close"><a href="#" id="'.$id.'" class="delete_button"><img src="assets/img/closepanel.png"></a></span></h2>'; 
        echo '<div class="dragbox-content" '; 
        if($user_site_0['collapsed']==1) 
         echo 'style="display:none;" '; 
        echo '>'; 
        echo '<p><a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"><img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/></a>'; 
        echo '<p>' . $site_category . '</p>'; 
        echo '<p>' . $site_address . '</p>'; 
        echo '<p>' . $site_desc . '</p>'; 
        echo' </div> 
        </div>'; 

       } 

      } 
      echo '</div>'; 



    ?> 
    <?php 


      echo '<div class="column grid_3 clearfix" id="column1" >'; 
      echo '&nbsp;'; 
      $user_sites_1=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='1' ORDER BY sort_no"); 

      if(!$user_sites_1) { 
       echo ''; 
      } 
      else { 

       while($user_site_1=mysqli_fetch_array($user_sites_1)) 
       { 
        $id = stripslashes($user_site_1['id']); 
        $site_name = stripslashes($user_site_1['site_name']); 
        $site_address = stripslashes($user_site_1['site_address']); 
        $site_desc = stripslashes($user_site_1['site_desc']); 
        $site_category = stripslashes($user_site_1['site_category']); 
        $getImage = 'http://immediatenet.com/t/s?Size=1024x768&URL='.$site_address; 

        echo '<div class="dragbox" id="item'.$id.'">'; 
        echo '<h2 class="h2handle">'.$site_name.' <span class="close"><a href="#" id="'.$id.'" class="delete_button"><img src="assets/img/closepanel.png"></a></span></h2>'; 
        echo '<div class="dragbox-content" '; 
        if($user_site_1['collapsed']==1) 
         echo 'style="display:none;" '; 
        echo '>'; 
        echo '<p><a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"><img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/></a>'; 
        echo '<p>' . $site_category . '</p>'; 
        echo '<p>' . $site_address . '</p>'; 
        echo '<p>' . $site_desc . '</p>'; 
        echo' </div> 
        </div>'; 

       } 
      } 
      echo '</div>'; 



    ?> 
    <?php 


      echo '<div class="column grid_3 clearfix" id="column2">'; 
      echo '&nbsp;'; 
      $user_sites_2=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='2' ORDER BY sort_no"); 

      if(!$user_sites_2) { 
       echo ''; 
      } 
      else { 

       while($user_site_2=mysqli_fetch_array($user_sites_2)) 
       { 
        $id = stripslashes($user_site_2['id']); 
        $site_name = stripslashes($user_site_2['site_name']); 
        $site_address = stripslashes($user_site_2['site_address']); 
        $site_desc = stripslashes($user_site_2['site_desc']); 
        $site_category = stripslashes($user_site_2['site_category']); 
        $getImage = 'http://immediatenet.com/t/s?Size=1024x768&URL='.$site_address; 

        echo '<div class="dragbox" id="item'.$id.'">'; 
        echo '<h2 class="h2handle">'.$site_name.' <span class="close"><a href="#" id="'.$id.'" class="delete_button"><img src="assets/img/closepanel.png"></a></span></h2>'; 
        echo '<div class="dragbox-content" '; 
        if($user_site_2['collapsed']==1) 
         echo 'style="display:none;" '; 
        echo '>'; 
        echo '<p><a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"><img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/></a>'; 
        echo '<p>' . $site_category . '</p>'; 
        echo '<p>' . $site_address . '</p>'; 
        echo '<p>' . $site_desc . '</p>'; 
        echo' </div> 
        </div>'; 
       } 
      } 
      echo '</div>';    

    ?> 
    <?php 


      echo '<div class="column grid_3 clearfix" id="column3">'; 
      echo '&nbsp;'; 
      $user_sites_3=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='3' ORDER BY sort_no"); 

      while($user_site_3=mysqli_fetch_array($user_sites_3)) 
      { 
       $id = stripslashes($user_site_3['id']); 
       $site_name = stripslashes($user_site_3['site_name']); 
       $site_address = stripslashes($user_site_3['site_address']); 
       $site_desc = stripslashes($user_site_3['site_desc']); 
       $site_category = stripslashes($user_site_3['site_category']); 
       $getImage = 'http://immediatenet.com/t/s?Size=1024x768&URL='.$site_address; 

       echo '<div class="dragbox" id="item'.$id.'">'; 
       echo '<h2 class="h2handle">'.$site_name.' <span class="close"><a href="#" id="'.$id.'" class="delete_button"><img src="assets/img/closepanel.png"></a></span></h2>'; 
       echo '<div class="dragbox-content" '; 
       if($user_site_3['collapsed']==1) 
        echo 'style="display:none;" '; 
       echo '>'; 
       echo '<p><a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"><img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/></a>'; 
       echo '<p>' . $site_category . '</p>'; 
       echo '<p>' . $site_address . '</p>'; 
       echo '<p>' . $site_desc . '</p>'; 
       echo' </div> 
       </div>'; 
      } 
      echo '</div>';    

    ?>

的代碼看起來正確的狀態..莫非我做得更好？

來源

2011-10-09 Daniel Cheeseman

+2

你要求的代碼的改進？那麼你應該使用http://codereview.stackexchange.com/。 – vstm

+0

模板引擎從不會傷害任何人...一百萬回聲的效率會受到質疑，以及代碼的可維護性。 – 2011-10-09 09:17:16

+0

我正在考慮這個問題，但是想從頭開始編碼學習..我買不起uni所以使用2個最好的東西..谷歌和堆棧溢出:) –

回答

3

使用for和更改代碼，一些代碼：

<?php 

for ($i=0; $i<4; $i++) 
{ 
    echo '<div class="column grid_3 clearfix" id="column'.$i.'" >'; 
    echo '&nbsp;'; 
    $user_sites=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='".$i."' ORDER BY sort_no"); 
    if(!$user_sites) { 
    echo 'No sites added, please <a class="addsite" href="#">add one now</a>'; 
    } 
    else 
    { 
    while($user_site=mysqli_fetch_array($user_sites)) 
    { 
     ... // Do it yourself

來源

2011-10-09 09:12:51 deepmax

+0

我想+1，但需要15個代表。謝謝你的回答！ :) –

0

也許

function get_site($column_id){ 
    $str = ""; 

    $user_sites = mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='".$column_id."' ORDER BY sort_no"); 
    if(!$user_sites_0) { 
       echo 'No sites added, please <a class="addsite" href="#">add one now</a>'; 
      } 
      else { 
      while($user_site_0=mysqli_fetch_array($user_sites_0)) 
       { 
        $id = stripslashes($user_site_0['id']); 
        $site_name = stripslashes($user_site_0['site_name']); 
        $site_address = stripslashes($user_site_0['site_address']); 
        $site_desc = stripslashes($user_site_0['site_desc']); 
        $site_category = stripslashes($user_site_0['site_category']); 
        $getImage = 'http://immediatenet.com/t/s?Size=1024x768&URL='.$site_address; 
        $str.= '<div class="dragbox" id="item'.$id.'">'; 
        $str.= '<h2 class="h2handle">'.$site_name.' <span class="close"><a href="#" id="'.$id.'" class="delete_button"><img src="assets/img/closepanel.png"></a></span></h2>'; 
        $str.= '<div class="dragbox-content" '; 
        if($user_site_0['collapsed']==1) 
         echo 'style="display:none;" '; 
        $str.= '>'; 
        $str.= '<p><a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"><img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/></a>'; 
        $str.= '<p>' . $site_category . '</p>'; 
        $str.= '<p>' . $site_address . '</p>'; 
        $str.= '<p>' . $site_desc . '</p>'; 
        $str.=' </div> 
        </div>'; 

       } 
      } 
      $str.='</div>'; 
      return $str;} 

echo '<div class="column grid_3 clearfix" id="column0">'; 
echo '&nbsp;'; 
echo oget_site(0); 

echo '<div class="column grid_3 clearfix" id="column1">'; 
echo '&nbsp;'; 
echo oget_site(1); 
//....

來源

2011-10-09 09:12:33 Mike

相關問題

 相關問題