錯誤與SQL Server過程動態

Question

我已經寫了這是工作的罰款與最值的，但一些價值它給我的錯誤作爲SQL Server過程：

必須聲明標量變量「@CourseID 」。

我沒有太多的程序經驗，請幫忙，另請參閱參數定義和參數順序。

ALTER PROCEDURE [dbo].[prStudentLoadByStudentAtt] 86 
    @StID int 
AS 
    DECLARE @SemID int 
    DECLARE @CourseID int 

    DECLARE @SQLQuery as nvarchar(4000) 
    DECLARE @ParamDefinition as nvarchar(4000) 

BEGIN 
    -- SET NOCOUNT ON added to prevent extra result sets from 
    -- interfering with SELECT statements. 
    SET NOCOUNT ON; 

    -- Insert statements for procedure here 
    set @SQLQuery = 'SELECT distinct dbo.tbSubjects.SubjectName,dbo.tbSubjects.SubCode, dbo.tbSubjects.SemID, dbo.tbStudent.StudentID, dbo.tbStudent.Name, dbo.tbStudent.RollNo, dbo.tbStudent.RegNo, dbo.tbAttendanceMaster.SubID, dbo.fnTotalDays(dbo.tbAttendanceMaster.SubID, dbo.tbStudent.StudentID) AS Total, 
         dbo.fnNoOfDays(dbo.tbAttendanceMaster.SubID, dbo.tbStudent.StudentID) AS Present, dbo.fnPerDays(dbo.tbAttendanceMaster.SubID, dbo.tbStudent.StudentID) 
         AS Percentage, ISNULL(dbo.tbSemester.SemName, ''Not Available'') AS SemName 
FROM dbo.tbAttendance INNER JOIN dbo.tbAttendanceMaster ON dbo.tbAttendance.MasterAID = dbo.tbAttendanceMaster.AtdID INNER JOIN dbo.tbStudent ON dbo.tbAttendance.StID = dbo.tbStudent.StudentID INNER JOIN dbo.tbSubjects ON dbo.tbAttendanceMaster.SubID = dbo.tbSubjects.SubID LEFT OUTER JOIN dbo.tbSemester ON dbo.tbSubjects.SemID = dbo.tbSemester.SemID 
    WHERE dbo.tbStudent.StudentID=@StID ' 

    SELECT @CourseID = CourseID FROM tbStudent WHERE StudentID = @StID 
    SELECT @SemID = SemID FROM tbStudent WHERE StudentID = @StID 

    IF (ISNULL(@SemID, 0) = 0) 
    BEGIN 
     set @SQLQuery=@SQLQuery+' and dbo.tbStudent.CourseID=@CourseID ' 
    end 
    else 
    begin 
     set @SQLQuery=@SQLQuery+' and dbo.tbStudent.SemID=@SemID ' 
    end 

    set @ParamDefinition = '@SemID int, @StID int' 

    Execute sp_Executesql @SQLQuery, @ParamDefinition, @SemID, @StID 

    return 
END 

Answer 1

改變這兩條線的CourseId傳遞到動態創建的SQL

set @ParamDefinition='@SemID int, @StID int, @CourseId int' 

Execute sp_executesql @SQLQuery, @ParamDefinition, @SemID, @StID, @CourseId 

Answer 2

真的不知道爲什麼你必須擺在首位在這裏所有這些動態SQL。很確定你的整個過程可以簡化爲一個選擇語句。像這樣的東西。

select * 
from dbo.tbAttendance a 
INNER JOIN dbo.tbAttendanceMaster am ON a.MasterAID = am.AtdID 
INNER JOIN dbo.tbStudent s ON a.StID = s.StudentID 
INNER JOIN dbo.tbSubjects su ON am.SubID = su.SubID 
LEFT OUTER JOIN dbo.tbSemester sem ON su.SemID = sem.SemID 
WHERE s.StudentID = @StID 
    AND s.CourseID = isnull(su.CourseID, s.CourseID) 
    AND s.SemID = ISNULL(su.SemID, s.SemID)