Rails錯誤 - 訂閱失敗

Question

我使用Rails構建一個Event應用程序。我最近改變了我的預訂控制器，以適應免費的活動。應用程序的這一面似乎工作正常，但當我嘗試爲付費活動進行測試預訂時，應用程序在完成付款提交表單後默認爲「預訂不成功」。

我不確定爲什麼會發生這種情況。這裏是我的控制器邏輯 -

def new 

     @event = Event.find(params[:event_id]) 
     @booking = Booking.new 
     @booking.user = current_user 



    end 

    def create 
     @event = Event.find(params[:event_id]) 
     @booking = Booking.new(booking_params) 
     @booking.user = current_user 


      if 
       @booking.save 
       flash[:success] = "Your place on our event has been booked" 
       redirect_to event_booking_path(@event, @booking) 
      else 
       flash[:error] = "Booking unsuccessful" 
       render "new" 
      end 

    end 

    def show 
     @event = Event.find(params[:event_id]) 
     @booking = Booking.find(params[:id]) 
    end 


    def update 

     if @booking.update(booking_params) 
      redirect_to event_booking_path(@event, @booking) , notice: "Booking was successfully updated!" 
     else 
      render 'new' 
     end 
    end 




    private 

    def booking_params 
     params.require(:booking).permit(:stripe_token, :booking_number, :quantity, :event_id, :stripe_charge_id, :total_amount) 
    end 

而且在我的模型我有這個 -

Booking.rb

class Booking < ActiveRecord::Base 

    belongs_to :event 
    belongs_to :user 


    before_create :set_booking_number 

    validates :quantity, presence: true, numericality: { greater_than_or_equal_to: 0 } 
    validates :total_amount, presence: true, numericality: { greater_than_or_equal_to: 0 } 
    validates :quantity, :total_amount, :booking_number, presence: true 

    def set_booking_number 
    self.booking_number = "MAMA" + '- ' + SecureRandom.hex(4).upcase 
    end 



    def booking 
     # Don't process this booking if it isn't valid 
     self.valid? 

      if booking.is_free? 
      self.total_amount = event.price_pennies.nil? 
      save! 
      end 



      begin 
         self.total_amount = event.price_pennies * self.quantity 
         charge = Stripe::Charge.create(
          amount: total_amount, 
          currency: "gbp", 
          source: stripe_token, 
          description: "Booking created for amount #{total_amount}") 
         self.stripe_charge_id = charge.id 
       self.booking_number = "MAMA" + '- ' + SecureRandom.hex(4).upcase 
         save! 
        rescue Stripe::CardError => e 
        errors.add(:base, e.message) 
        false 
       end 

    end 
end 

所以，由於某種原因，它不保存或還有別的東西不對。任何援助讚賞。

Answer 1

這是完整的代碼？你的「booking.rb」似乎完全錯誤。

您正在定義一個「預訂」方法，但我沒有看到您在任何地方調用它。 除了可能在預訂法本身，當你執行

if booking.is_free? 

你混的東西了嗎？

Answer 2

好的，讓我們來看看。

我想你需要的東西是這樣的：

class Booking < ActiveRecord::Base 

    belongs_to :event 
    belongs_to :user 
    before_create :set_booking_number 
    ### new 
    before_save(:set_total_amount) 

    validates :quantity, presence: true, numericality: { greater_than_or_equal_to: 0 } 
    validates :total_amount, presence: true, numericality: { greater_than_or_equal_to: 0 } 
    validates :quantity, :total_amount, :booking_number, presence: true 
    ### new 
    validate(:validate_booking) 

    def set_booking_number 
    self.booking_number = "MAMA" + '- ' + SecureRandom.hex(4).upcase 
    end 

    def set_total_amount 
    # does event.is_free? exist? if not: either define .is_free? or use self.event.price_pennies.nil? or self.event.price_pennies.to_i == 0 
    if self.event.is_free? 
     # I am guessing total_amount is an Int but you are assigning a boolean 
     # self.total_amount = event.price_pennies.nil? 
     # should be 
     self.total_amount = 0 
    else 
     self.total_amount = event.price_pennies * self.quantity 
     begin 
     charge = Stripe::Charge.create(
      amount: total_amount, 
      currency: "gbp", 
      source: stripe_token, 
      description: "Booking created for amount #{total_amount}") 
     self.stripe_charge_id = charge.id 
     rescue Stripe::CardError => e 
     # if this fails stripe_charge_id will be null, but in case of update we just set it to nil again 
     self.stripe_charge_id = nil 
     # we check in validatition if nil 
     end 
     # booking number was already set, see set_booking_number 
     # self.booking_number = "MAMA" + '- ' + SecureRandom.hex(4).upcase 
    end 
    end 

    # is suppose to be a validation, so I renamed it 
    # def booking 
    def validate_booking 
    # Don't process this booking if it isn't valid 
    # will be called on .save anyway 
    # self.valid? 

    # I pushed this to set_total_amount (called by before_save) 
    # if booking.is_free? 
    #  self.total_amount = event.price_pennies.nil? 
    # Why call save! ? with "!" it will cast an exception if invalid 
    #  save! 
    # end 

    # also pushed to set_total_amount since this has nothing to do with validation 
    #  begin 
    #     self.total_amount = event.price_pennies * self.quantity 
    #     charge = Stripe::Charge.create(
    #      amount: total_amount, 
    #      currency: "gbp", 
    #      source: stripe_token, 
    #    description: "Booking created for amount #{total_amount}") 
    #     self.stripe_charge_id = charge.id 
    #  self.booking_number = "MAMA" + '- ' + SecureRandom.hex(4).upcase 
    #     save! 
    #    rescue Stripe::CardError => e 
    #    errors.add(:base, e.message) 
    #    false 
    #   end 

    # stripe_charge_id must be set for not free events 
    unless self.event.is_free? 
     return !self.stripe_charge_id.nil? 
    end 
    end 
end 

這當然是未經測試。但請放手。

我希望我的意見很明確。

Answer 3

終於突破了關於參數的一些工作，並在模型代碼上工作。下面是我的控制器和模型最終代碼 -

Booking.rb

class Booking < ActiveRecord::Base 

    belongs_to :event 
    belongs_to :user 
    before_create :set_booking_number 


    validates :quantity, presence: true, numericality: { greater_than_or_equal_to: 0 } 
    validates :total_amount, presence: true, numericality: { greater_than_or_equal_to: 0 } 

    validate(:validate_booking) 

    def set_booking_number 
    self.booking_number = "MAMA" + '- ' + SecureRandom.hex(4).upcase 
    end 

    def set_booking 

    if self.event.is_free? 
     self.total_amount = 0 
     save! 
    else 
     self.total_amount = event.price_pennies * self.quantity 
     begin 
     charge = Stripe::Charge.create(
      amount: total_amount, 
      currency: "gbp", 
      source: stripe_token, 
      description: "Booking created for amount #{total_amount}") 
     self.stripe_charge_id = charge.id 
     save! 
     rescue Stripe::CardError => e 
     self.stripe_charge_id = nil 

     end 
    end 
    end 

    unless self.event.is_free? 
     return !self.stripe_charge_id.nil? 
    end 
    end 
end 

Bookings_controller.rb

class BookingsController < ApplicationController 

    before_action :authenticate_user! 



    def new 
     @event = Event.find(params[:event_id]) 
     # and because the event "has_many :bookings" 
     @booking = Booking.new(params[:booking]) 
     @booking.user = current_user 



    end 

    def create 

     # actually process the booking 
     @event = Event.find(params[:event_id]) 
     @booking = @event.bookings.new(booking_params) 
     @booking.user = current_user 


      if 
       @booking.set_booking 
       flash[:success] = "Your place on our event has been booked" 
       redirect_to event_booking_path(@event, @booking) 
      else 
       flash[:error] = "Booking unsuccessful" 
       render "new" 
      end 

      if @event.is_free? 
       @booking.save(booking_params) 
      end 
    end 

    def show 
     @event = Event.find(params[:event_id]) 
     @booking = Booking.find(params[:id]) 
    end 


    def update 

     if @booking.update(booking_params) 
      redirect_to event_booking_path(@event, @booking) , notice: "Booking was successfully updated!" 
     else 
      render 'new' 
     end 
    end 




    private 

    def booking_params 
     params.require(:booking).permit(:stripe_token, :booking_number, :quantity, :event_id, :stripe_charge_id, :total_amount) 
    end 






end