SQL錯誤：查詢空

Question

mysql_select_db("musicDB", $con); 

$sql = mysql_query("INSERT INTO Users (username, fname, lname, email, dob, password, occupation, genre) 
VALUES ('$_POST[username]', '$_POST[fname]', '$_POST[lname]', '$_POST[email]', '$_POST[dob]', sha1('$_POST[password]'), '$_POST[occupation]', '$_POST[genre]')"); 

if (!mysql_query($sql,$con)) 
{ 
    die('Error: ' . mysql_error()); 
} 
echo "1 record added"; 
?> 

我新的PHP和我得到這個SQL錯誤：

The query is empty.

我在做什麼錯？

Answer 1

宣佈串查詢變量時，不使用$sql = mysql_query(...);只是簡單$sql = "...";，它應該正常工作

Answer 2

$sql = mysql_query("INSERT INTO Users (username, fname, lname, email, dob, password, occupation, genre) 
VALUES ('$_POST[username]', '$_POST[fname]', '$_POST[lname]', '$_POST[email]', '$_POST[dob]', sha1('$_POST[password]'), '$_POST[occupation]', '$_POST[genre]')"); 

if (!sql) 
{ 

是正確的。你試圖做

if(!mysql_query(mysql_query("...."))) 
{ 

Answer 3

mysql_select_db("musicDB", $con); 

// that's dirty but at least something to protect that silly code 
$_POST['password'] = sha1($_POST['password'].$_POST['username']); 
foreach($_POST as $key => $value) $_POST[$key] = mysql_real_escape_string($value); 

$sql = "INSERT INTO Users (username, fname, lname, email, dob, password, occupation, genre) 
     VALUES ('$_POST[username]', '$_POST[fname]', '$_POST[lname]', '$_POST[email]', 
       '$_POST[dob]', '$_POST[password]', '$_POST[occupation]', '$_POST[genre]')"); 

if (!mysql_query($sql,$con)) 
{ 
    trigger_error(mysql_error()." ".$sql); 
} else { 
    echo "1 record added"; 
} 
?>