嘲諷的OpenXML與起訂量

Question

我應該如何測試以下GetWorksheetPart方法：

public class ExcelDocument : IExcelDocument 
{ 
    private readonly string _filePath; 

    public ExcelDocument(string filePath) 
    { 
     _filePath = filePath; 
    } 

    public WorksheetPart GetWorksheetPart(ISpreadsheetDocument excelDoc, string sheetName) 
    { 
     Sheet sheet = excelDoc.GetSheet(sheetName); 
     if (sheet == null) 
     { 
      throw new ArgumentException(
       String.Format("No sheet named {0} found in spreadsheet {1}", 
        sheetName, _filePath), "sheetName"); 
     } 
     return excelDoc.GetPartById(sheet.Id); 
    } 
} 

凡IExcelDocument和包裝的SpreadsheetDocumentWrapper接口：

public interface IExcelDocument 
{ 
    WorksheetPart GetWorksheetPart(ISpreadsheetDocument excelDoc, string sheetName); 
} 

public interface ISpreadsheetDocument 
{ 
    Sheet GetSheet(string name); 

    WorksheetPart GetPartById(string id); 
} 

這裏是包裝本身。

public class SpreadsheetDocumentWrapper : ISpreadsheetDocument 
{ 
    private SpreadsheetDocument excelDoc; 

    public SpreadsheetDocumentWrapper(SpreadsheetDocument excelDoc) 
    { 
     this.excelDoc = excelDoc; 
    } 

    public Sheet GetSheet(string sheetName) 
    { 
     return excelDoc.WorkbookPart.Workbook.Descendants<Sheet>() 
        .SingleOrDefault(s => s.Name == sheetName); 
    } 

    public WorksheetPart GetPartById(string id) 
    { 
     return (WorksheetPart)excelDoc.WorkbookPart.GetPartById(id); 
    } 
} 

最後，我試圖實施的測試爲GetWorksheetPart。與此問題是，我不知道如何測試此功能。想法是得到一個WorksheetPart給定工作表名稱和電子表格文檔。

public class Test 
{ 
    [TestClass()] 
    public class ExcelUpdateLogicTests 
    { 
     [TestMethod()] 
     public void Excel_GetWorkseetPartTest() 
     { 
      Mock<ISpreadsheetDocument> mockSpreadhseet = new Mock<ISpreadsheetDocument>(); 
      Sheet sheet = new Sheet(); 
      string id = "1"; 
      sheet.Name = "sheet"; 
      sheet.Id = id; 

      mockSpreadhseet.Setup(doc => doc.GetSheet("sheet")).Returns(sheet); 

      mockSpreadhseet.Setup(doc => doc.GetPartById(id)).Returns(????); 

      Mock<IExcelDocument> mockExcelDocument = new Mock<IExcelDocument>(); 
      WorksheetPart mockWorkseet = mockExcelDocument.Object 
       .GetWorksheetPart(mockSpreadhseet.Object, "sheet"); 

      Assert.IsTrue(mockWorkseet.GetIdOfPart(mockWorkseet) == id); 
     } 
    } 
} 

這裏是電子表格一般的OpenXML結構樹：

   Spreadsheet 
         |   
       WorkbookPart  
     /  |    \ 
    Workbook WorkbookStylesPart WorksheetPart 
     |   |    | 
    Sheets  StyleSheet  Worksheet 
     |      /  \  
    (refers to    SheetData  Columns 
    Worksheetparts)   | 
          Rows 

Answer 1

由於ExcelDocument是被測系統那麼就沒有必要嘲笑IExcelDocument。你應該嘲笑測試SUT

現在我能得到你的測試通過這樣的需要/存根/假的依賴關係......

public class Test { 
    [TestClass()] 
    public class ExcelUpdateLogicTests { 
     [TestMethod()] 
     public void Given_SheetName_ExcelDocument_Should_GetWorkseetPart() { 
      //Arrange 
      var stream = new MemoryStream();//Avoid having to use actual file on disk 
      var spreadsheetDocument = SpreadsheetDocument.Create(stream, SpreadsheetDocumentType.Workbook); 

      // Add a WorkbookPart. 
      WorkbookPart workbookpart = spreadsheetDocument.AddWorkbookPart(); 
      workbookpart.Workbook = new Workbook(); 

      // Add a WorksheetPart. 
      WorksheetPart worksheetPart = workbookpart.AddNewPart<WorksheetPart>(); 
      worksheetPart.Worksheet = new Worksheet(new SheetData()); 

      // Add a sheets list. 
      Sheets sheets = spreadsheetDocument.WorkbookPart.Workbook.AppendChild<Sheets>(new Sheets()); 

      // Append the new worksheet and associate it with the workbook. 
      string expectedId = workbookpart.GetIdOfPart(worksheetPart); 
      string sheetName = "mySheet"; 

      Sheet sheet = new Sheet() { 
       Id = expectedId, 
       SheetId = 1, 
       Name = sheetName 
      }; 
      sheets.Append(sheet); 

      var wrapper = new SpreadsheetDocumentWrapper(spreadsheetDocument); 

      string fakeFilePath = "path"; 
      var sut = new ExcelDocument(fakeFilePath); 

      //Act 
      WorksheetPart result = sut.GetWorksheetPart(wrapper, sheetName); 

      //Assert 
      Assert.IsNotNull(result); 
      var actualId = workbookpart.GetIdOfPart(result); 
      Assert.AreEqual(expectedId, actualId); 
     } 
    } 
} 

這樣做的過程中卻提出了一些問題目前的設計。

如果創建抽象的目的是爲了隱藏實現細節並減少外部框架上的緊密耦合以使事情更容易模擬和測試，那麼必須創建實際的SpreadsheetDocument並將其包裝爲測試似乎是多餘的。

框架的很多部分都難以嘲笑他們的內部世代。我會隱藏那些隱藏在其他抽象背後的東西，但鑑於我對這個系統的最終目標不夠了解，我不能建議你應該採用什麼設計結構。