2012-02-19 83 views
4

在此輸入代碼我正試圖完成邁克爾哈特爾的Ruby on Rails v3.2教程和我卡在Chapter 9.2.2RoR v3.2教程 - 卡住章9.2.2

下面是失敗的消息,我得到即使學完本節之後,我所有的測試應該通過:

sample_app mikael$ bundle exec rspec spec/ 
.................................................................F.. 

Failures: 

    1) User pages edit with valid information 
    Failure/Error: it { should have_link('Sign out', :href => signout_path) } 
     expected link "Sign out" to return something 
    # ./spec/requests/user_pages_spec.rb:91:in `block (4 levels) in <top (required)>' 

Finished in 2.42 seconds 
68 examples, 1 failure 

Failed examples: 

rspec ./spec/requests/user_pages_spec.rb:91 # User pages edit with valid information 

的問題是,經過一個登錄的用戶成功地更新他們的個人資料會被自動登出,引起使用有效信息測試進行編輯會失敗,因爲更新用戶之後應該保持登錄狀態,並且應該存在「退出」鏈接。

我已經梳理了這個尋找我的錯誤,或者我沒有正確地按照教程,但無法找到解決方案。

我可以讓我的所有測試結束,直到完成第9.2.2節後。

下面是我在第9章更新的文件(包括部分9.2.2及以前的所有部分):

規格/請求/ authentication_pages_spec.rb

require 'spec_helper' 

describe "Authentication" do 

    subject { page } 

    describe "signin page" do 
    before { visit signin_path } 

    it { should have_selector('h1', text: 'Sign in') } 
    it { should have_selector('title', text: 'Sign in') } 

    end 

    describe "signin" do 
    before { visit signin_path } 

    describe "with invalid information" do 
    before { click_button "Sign in" } 

    it { should have_selector('title', text: 'Sign in') } 
    it { should have_selector('div.flash.error', text: 'Invalid') } 

     describe "after visiting another page" do 
     before { click_link "Home" } 
     it { should_not have_selector('div.flash.error') } 
     end 
    end 

    describe "with valid information" do 
     let(:user) { FactoryGirl.create(:user) } 
     before do 
     fill_in "Email", with: user.email 
     fill_in "Password", with: user.password 
     click_button "Sign in" 
     end 

     it { should have_selector('title', text: user.name) } 
     it { should have_link('Profile', href: user_path(user)) } 
     it { should have_link('Settings', href: edit_user_path(user)) } 
     it { should have_link('Sign out', href: signout_path) } 
     it { should_not have_link('Sign in', href: signin_path) } 

     describe "followed by signout" do 
     before { click_link "Sign out" } 
     it { should have_link('Sign in') } 
     end 
    end 
    end 

    describe "authorization" do 

    describe "for non-signed-in users" do 
     let(:user) { Factory(:user) } 

     describe "in the Users controller" do 

     describe "visiting the edit page" do 
      before { visit edit_user_path(user) } 
      it { should have_selector('title', text: 'Sign in') } 
     end 

     describe "submitting to the update action" do 
      before { put user_path(user) } 
      specify { response.should redirect_to(signin_path) } 
     end 
     end 
    end 

    describe "as wrong user" do 
     let(:user) { FactoryGirl.create(:user) } 
     let(:wrong_user) { FactoryGirl.create(:user, email: "[email protected]") } 
     before { sign_in user } 

     describe "visiting Users#edit page" do 
     before { visit edit_user_path(wrong_user) } 
     it { should have_selector('title', text: 'Home') } 
     end 

     describe "submitting a PUT request to the Users#update action" do 
     before { put user_path(wrong_user) } 
     specify { response.should redirect_to(root_path) } 
     end 
    end 
    end 
end 

規格/請求/ user_pages_spec.rb

require 'spec_helper' 

describe "User pages" do 

    subject { page } 

    describe "profile page" do 
    let(:user) { FactoryGirl.create(:user) } 
    before { visit user_path(user) } 

    it { should have_selector('h1', text: user.name) } 
    it { should have_selector('title', text: user.name) } 
    end 

    describe "signup" do 

    before { visit signup_path } 

    describe "with invalid information" do 
     it "should not create a user" do 
     expect { click_button "Sign up" }.not_to change(User, :count) 
     end 
     end 

    describe "error messages" do 
     before { click_button "Sign up" } 

     let(:error) { 'errors prohibited this user from being saved' } 

     it { should have_selector('title', text: 'Sign up') } 
     it { should have_content(error) } 
    end 

    describe "with valid information" do 
     before do 
     fill_in "Name",   with: "Example User" 
     fill_in "Email",  with: "[email protected]" 
     fill_in "Password",  with: "foobar" 
     fill_in "Confirmation", with: "foobar" 
     end 

     describe "after saving the user" do 
     before { click_button "Sign up" } 
     let(:user) { User.find_by_email('[email protected]') } 

     it { should have_selector('title', text: user.name) } 
     it { should have_selector('div.flash.success', text: 'Welcome') } 
     it { should have_link('Sign out') } 
     end 

    it "should create a user" do 
     expect { click_button "Sign up" }.to change(User, :count).by(1) 
     end 
    end 
    end 

    describe "edit" do 
    let(:user) { FactoryGirl.create(:user) } 
    before do 
      sign_in user 
      visit edit_user_path(user) 
     end 

    describe "page" do 
     it { should have_selector('h1', text: "Edit user") } 
     it { should have_selector('title', text: "Edit user") } 
     it { should have_link('change', href: 'http://gravatar.com/emails') } 
    end 

    describe "with invalid information" do 
     let(:error) { '1 error prohibited this user from being saved' } 
     before { click_button "Update" } 

     it { should have_content(error) } 
    end 

    describe "with valid information" do 
     let(:user)  { FactoryGirl.create(:user) } 
     let(:new_name) { "New Name" } 
     let(:new_email) { "[email protected]" } 
     before do 
     fill_in "Name",   with: new_name 
     fill_in "Email",  with: new_email 
     fill_in "Password",  with: user.password 
     fill_in "Confirmation", with: user.password 
     click_button "Update" 
     end 

     it { should have_selector('title', text: new_name) } 
     it { should have_selector('div.flash.success') } 
     it { should have_link('Sign out', :href => signout_path) } 
     specify { user.reload.name.should == new_name } 
     specify { user.reload.email.should == new_email } 
    end 
    end 
end 

應用/ C ontrollers/users_controller.rb

class UsersController < ApplicationController 
    before_filter :signed_in_user, only: [:edit, :update] 
    before_filter :correct_user, only: [:edit, :update] 

    def show 
    @user = User.find(params[:id]) 
    end 

    def new 
    @user = User.new 
    end 

    def create 
    @user = User.new(params[:user]) 
    if @user.save 
     sign_in @user 
     flash[:success] = "Welcome to MK Rails!" 
     redirect_to @user 
    else 
     render 'new' 
    end 
    end 

    def edit 
    end 

    def update 
    if @user.update_attributes(params[:user]) 
     flash[:success] = "Profile updated" 
     redirect_to @user 
    else 
     render 'edit' 
    end 
    end 

    private 

     def signed_in_user 
     redirect_to signin_path, notice: "Please sign in." unless signed_in? 
     end 

     def correct_user 
     @user = User.find(params[:id]) 
     redirect_to(root_path) unless current_user?(@user) 
     end 
end 

應用程序/傭工/ sessions_helper.rb

module SessionsHelper 

    def sign_in(user) 
    cookies.permanent[:remember_token] = user.remember_token 
    current_user = user 
    end 

    def signed_in? 
    !current_user.nil? 
    end 

    def current_user=(user) 
    @current_user = user 
    end 

    def current_user 
    @current_user ||= user_from_remember_token 
    end 

    def current_user?(user) 
    user == current_user 
    end 

    def sign_out 
    cookies.delete(:remember_token) 
    end 

    private 

    def user_from_remember_token 
     remember_token = cookies[:remember_token] 
     User.find_by_remember_token(remember_token) unless remember_token.nil? 
    end 
end 

規格/支持/ utilities.rb

def full_title(page_title) 
    base_title = "MK Rails" 
    if page_title.empty? 
    base_title 
    else 
    "#{base_title} | #{page_title}" 
    end 
end 

def valid_signin(user) 
    fill_in "Email", with: user.email 
    fill_in "Password", with: user.password 
    click_button "Sign in" 
end 

RSpec::Matchers.define :have_error_message do |message| 
    match do |page| 
    page.should have_selector('div.flash.error', text: message) 
    end 
end 

def sign_in(user) 
    visit signin_path 
    fill_in "Email", with: user.email 
    fill_in "Password", with: user.password 
    click_button "Sign in" 
    # Sign in when not using Capybara as well. 
    cookies[:remember_token] = user.remember_token 
end 

理解任何幫助問題非常感謝!

回答

3

你可以只自動登錄他們回來時,他們更新他們的個人資料:

def update 
    if @user.update_attributes(params[:user]) 
    sign_in @user 
    flash[:success] = "Profile updated" 
    redirect_to @user 
    else 
    render 'edit' 
    end 
end 
+0

謝謝,這樣做!很容易修復,但我仍然困惑,爲什麼它不能正確工作。我擔心這是我從前一章中遺漏的小事,儘管直到這一點的所有事情都非常順利。快速的問題 - 你不認爲這個修復會有任何不利影響,會危及用戶的安全/身份驗證等與你的應用程序? – mkp 2012-02-20 00:58:44

+0

它簽名的原因是因爲在'User'模型中(在Rails by Example教程中)有一個'before_save'回調,它會在保存當前會話無效時更改'remember_token'。解決方案的唯一副作用是,如果在以後引入用戶級別(例如管理員可以更新用戶配置文件),則需要執行檢查(例如'sign_in @user if current_user.id == @user。 id')。否則,管理員將以用戶更新的個人資料登錄。 – pjumble 2012-02-20 01:14:56

+0

真棒,感謝您的洞察力! – mkp 2012-02-20 02:44:26

0

我相信你缺少更新在上市規格/支持/ utilities.rb的sign_in(用戶)方法9.6:

def sign_in(user, options = {}) 
    if options[:nocapybara] 
    remember_token = User.new_remember_token 
    cookies[:remember_token] = remember_token 
    user.update_attribute(:remember_token, User.encrypt(remember_token)) 
    else 
    visit signin_path 
    fill_in "Email",  with: user.email.upcase 
    fill_in "Password", with: user.password 
    click_button "Sign in" 
    end 
end 

,還缺少更新同名的在app /傭工/ sessions_helper.rb的方法,你會發現在上市8.2.3發現:

def sign_in(user) 
    remember_token = User.new_remember_token 
    cookies.permanent[:remember_token] = remember_token 
    user.update_attribute(:remember_token, User.encrypt(remember_token)) 
    self.current_user = user 
end