2016-04-24 73 views
0

我有BaseController:如何在抽象BaseController中創建通用'/ ping'API資源?

@Controller 
public abstract class BaseController { 

    /** 
    * The Logger for this class hierarchy 
    */ 
    protected Logger logger = LoggerFactory.getLogger(this.getClass()); 

    @RequestMapping(value = "/ping", produces = MediaType.APPLICATION_JSON_VALUE) 
    public ServiceResponse<?> ping() { 
     ServiceResponse<Object> serviceResponse = new ServiceResponse<>(ResponseStatus.SUCCESS); 
     return serviceResponse; 
    } 
} 

,很少擴展這個BaseController這樣其他控制器:

@RestController 
@RequestMapping(value= "/admin") 
public class AdminController extends BaseController { 

    @RequestMapping(
      value = "/all", 
      method = RequestMethod.GET, 
      produces = MediaType.APPLICATION_JSON_VALUE) 
    public ServiceResponse<List<Account>> getAll() { 
     ServiceResponse<List<Account>> serviceResponse = accountService.getAll(); 
     return serviceResponse; 
    } 
} 

但只要我搬到平()資源BaseController我得到的服務器啓動時出現錯誤:

2016-04-23 21:31:39.862 ERROR 2335 --- [   main] o.s.boot.SpringApplication    : Application startup failed 

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'requestMappingHandlerMapping' defined in class path resource [org/springframework/boot/autoconfigure/web/WebMvcAutoConfiguration$EnableWebMvcConfiguration.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: Ambiguous mapping. Cannot map 'clientController' method 
public ca.gatin.api.response.ServiceResponse<?> ca.gatin.api.controller.BaseController.ping() 
to {[/admin/ping],produces=[application/json]}: There is already 'adminController' bean method 
public ca.gatin.api.response.ServiceResponse<?> ca.gatin.api.controller.BaseController.ping() mapped. 
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1578) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:545) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:482) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:772) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:839) ~[spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:538) ~[spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE] 
    at org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:118) ~[spring-boot-1.3.3.RELEASE.jar:1.3.3.RELEASE] 
    at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:766) [spring-boot-1.3.3.RELEASE.jar:1.3.3.RELEASE] 
    at org.springframework.boot.SpringApplication.createAndRefreshContext(SpringApplication.java:361) [spring-boot-1.3.3.RELEASE.jar:1.3.3.RELEASE] 
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:307) [spring-boot-1.3.3.RELEASE.jar:1.3.3.RELEASE] 
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1191) [spring-boot-1.3.3.RELEASE.jar:1.3.3.RELEASE] 
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1180) [spring-boot-1.3.3.RELEASE.jar:1.3.3.RELEASE] 
    at ca.gatin.TodoAppApplication.main(TodoAppApplication.java:10) [classes/:na] 

這只是,我不想在多個控制器中重複ping()資源。我如何正確地將它移動到BaseController?

+0

您是否想要擴展BaseController的每個控制器(例如'admin/ping')的ping映射?或者一個'/ ping'映射,而不管你創建了多少個BaseController子類? –

+0

我想將ping方法放在requestMapping的根目錄/ ping –

回答

1

我tlooks像你使用的是其他

class ClientController extends BaseController 

兩個ClientController和AdminController地圖/平其繼承的方法平()。 Spring只能映射/ ping到這個或那個,這就是爲什麼你會得到這個異常。

你正在寫

我不想重複平()資源在多個控制器

,也沒有必要做這個。把你的ping()方法放在它自己的控制器中,將它從BaseControler中移除,就是這樣。

無論如何,我不會要求在控制器中使用繼承,它使事情變得複雜得多。

+0

謝謝您的回答!是的,你是對的ClientController和AdminController擴展BaseController。如果我把Ping()方法放到ClientController和AdminController中,那麼它將在這些控制器中重複同樣的方法... –