遞歸地在末尾插入單鏈表c

Question

任何人都可以告訴我我的代碼有什麼問題嗎？
我想創建非返回函數void在鏈表的末尾插入一個節點。

void insert_tail_Recursively(struct node **phead, int key) { 
    if (*phead == NULL) { 
    Node*temp = malloc(sizeof(Node)); 
    temp->data = key; 
    temp->pLeft = temp->pRight = NULL; 
    *phead = temp; 
    } else { 
    Node*temp = malloc(sizeof(Node)); 
    temp->data = key; 
    temp->pLeft = temp->pRight = NULL; 

    /* data more than root node data insert at right */ 
    if ((temp->data > (*phead)->data) && ((*phead)->pRight != NULL)) 
     insert_tail_Recursively((*phead)->pRight, key); 
    else if ((temp->data > (*phead)->data) && ((*phead)->pRight == NULL)) { 
     (*phead)->pRight = temp; 

    } 

    /* data less than root node data insert at left */ 
    else if ((temp->data < (*phead)->data) && ((*phead)->pLeft != NULL)) 
     insert_tail_Recursively((*phead)->pLeft, key); 
    else if ((temp->data < (*phead)->data) && ((*phead)->pLeft == NULL)) { 
     (*phead)->pLeft = temp; 
    } 
    } 
} 

Answer 1

您的代碼過於複雜，導致錯誤。例如有內存泄漏。

看來你的意思是以下。

void insert_tail_Recursively(struct node **phead, int key) 
{ 
    if (*phead == NULL) 
    { 
     *phead = malloc(sizeof(struct node)); 
     (*phead)->data = key; 
     (*phead)->pLeft = (*phead)->pRight = NULL; 
    } 
    else 
    { 
     phead = key < (*phead)->data ? &(*phead)->pLeft : &(*phead)->pRight; 
     insert_tail_Recursively(phead, key); 
    } 
}