foreach（）循環輸出數據和創建佈局

Question

我目前正在嘗試創建一個班級時間表，我從我的Sql Server數據庫中使用PHP進行抽取，並且試圖獲取佈局輸出以及數據，因爲我正在分組資源。

這些分組嵌套如：

-DAY 
--TIME 
---CLASS 
----STUDENTS 

而且應該像這樣的輸出：

不過，我得到這個：

我的電流輸出工作，但，它只在第一個循環中，然後一切都變得不合時宜。我假設我的代碼中有一個錯誤的</div>標記，但我無法爲我的生活找到它。

我的PHP代碼是一個函數，delcare這樣：

<div class="mainScheduleWrapper"> 
    <?php daySchedule(); ?> 
</div> 

我的PHP代碼是這樣的：

function daySchedule() { 
    global $conn; 
    $dayScheduleQuery = 'SET DATEFIRST 1 
       SELECT [DAY].[DAY] AS [DAY], CLASS.CLASSTIME AS CLASSTIME, CLASSLEVEL.CLASSLEVEL AS CLASSLEVEL, CLASS.MAXSTUDENT AS MAXSTUDENT, INSTRUCTOR.FIRSTNAME AS INSTRUCTOR, STUDENT.FIRSTNAME AS STUDENTFIRST, STUDENT.SURNAME AS STUDENTLAST, STUDENT.DOB AS STUDENTDOB 
       FROM STUDENT JOIN BOOKING ON STUDENT.ID = BOOKING.STUDENTID JOIN CLASS ON CLASS.ID = BOOKING.CLASSID JOIN CLASSLEVEL ON CLASS.CLASSLEVELID = CLASSLEVEL.ID JOIN [DAY] ON CLASS.CLASSDAY = [DAY].ID JOIN INSTRUCTOR ON CLASS.INSTRUCTORID = INSTRUCTOR.ID 
       WHERE [DAY].ID = (DATEPART(dw, GETUTCDATE() AT TIME ZONE \'AUS Eastern Standard Time\')) 
       ORDER BY CLASS.CLASSTIME ASC, INSTRUCTOR.FIRSTNAME ASC, CLASSLEVEL.CLASSLEVEL ASC'; 

    // COUNTERS 
    $t = 0; 
    $i = 0; 

    //VARIABLES FOR DAY SCHEDULE 
    $classDay = NULL; 
    $classTime = NULL; 
    $classInstructor = NULL; 
    $closeClass = false; 
    $closeAll = false; 
    $queryConnector = $conn->query($dayScheduleQuery); 

    foreach ($queryConnector as $schedule) { 

     // CLASS DAY HEADER 
     if ($classDay != $schedule['DAY']) { 

      echo '<div class="grid-1">'; 
      echo '<h1>' . $schedule['DAY'] . '</h1>'; 
      echo '</div><!-- Day closed! -->'; 
      $classDay = $schedule['DAY']; 

     } 

     // CLASS TIME HEADER 
     if ($classTime != $schedule['CLASSTIME']) { 

      if($classTime != $schedule['CLASSTIME'] && $t > 0) { 
       $closeAll = true; 
       goto closeAll; 
      } 

      echo '<div class="grid-12-noGutter scheduleContainer">'; //NON-CLOSED 
      echo '<h1>' . 'T = ' . $t . '</h1>'; 
      echo '<div class="grid-middle-center col scheduleTimeTab">'; 
       // FIX 3 DIGIT MILITARY TIME 
       if (strlen($schedule['CLASSTIME']) < 4) { 
        $classScheduleTime = '0' . $schedule['CLASSTIME']; 
       } else { 
        $classScheduleTime = $schedule['CLASSTIME']; 
       } 
       echo '<p>' . date('g:i A', strtotime($classScheduleTime)) . '</p>'; 
      echo '</div>'; //CLOSE TIME TAB 

      echo '<div class="innerSchedule">'; // NON-CLOSED 

      $classTime = $schedule['CLASSTIME']; 
      $t += 100; 

     } 
     // INSTRUCTOR HEADER 
     if ($classInstructor != $schedule['INSTRUCTOR']) { 

      if ($classInstructor != $schedule['INSTRUCTOR'] && $i > 0) { 
       $closeClass = true; 
       goto closeClassWrapper; 
      } 

      echo '<div class="classWrapper">'; 
      echo '<h1>' . 'I =' . $i . 'T = ' . $t . '</h1>'; 
       echo '<div class="grid-3-middle classHeader">'; 
        echo '<div class="col classHeaderCell' . classLevelColour($schedule['CLASSLEVEL']) . '">' . $schedule['CLASSLEVEL'] . '</div>'; 
        echo '<div class="col classHeaderCell">' . $schedule['INSTRUCTOR'] . '</div>'; 
        echo '<div class="col classHeaderCell">Max' . ' ' . $schedule['MAXSTUDENT'] . '</div>'; 
       echo '</div>'; 
       echo '<div class="grid-4-middle" id="studentHeaders">'; 
        echo '<div class="col"><h6>Student Name</h6></div>'; 
        echo '<div class="col"><h6>Student Birthday</h6></div>'; 
        echo '<div class="col"><h6>Class Level</h6></div>'; 
        echo '<div class="col"><h6>Attendance</h6></div>'; 
       echo '</div>'; 

      $classInstructor = $schedule['INSTRUCTOR']; 
      $i += 100; 

     } 
     echo '<div class="grid-4 studentRow">'; 
      echo '<div class="col">'; 
       echo '<span class="studentCell">' . $schedule['STUDENTFIRST'] . ' ' . $schedule['STUDENTLAST'] . '</span>'; 
      echo '</div>'; 
      echo '<div class="col">'; 
       echo '<span class="studentCell">' . $schedule['STUDENTDOB'] . '</span>'; 
      echo '</div>'; 
      echo '<div class="col">'; 
       echo '<span class="studentCell">' . $schedule['CLASSLEVEL'] . '</span>'; 
      echo '</div>'; 
      echo '<div class="col">'; 
       echo '<span class="studentCell">--</span>'; 
      echo '</div>'; 
     echo '</div>'; 

     // GOTO TAGS 
     closeClassWrapper: { 
      if ($closeClass === true) { 
       echo '</div>'; 
       $closeClass = false; 
       $i = 0; 
      } 
     } 

     closeAll: { 
      if ($closeAll === true) { 
       echo '</div>'; 
       echo '</div>'; 
       echo '</div>'; 
       $closeAll = false; 
       $t = 0; 
       $i = 0; 
      } 
     } 
    } 
} 

任何幫助將不勝感激 - 即使它是來告訴我我會以完全錯誤的方式去解決這個問題。

最親切的問候 邁克爾ž

Answer 1

我不會說你要關於它的完全錯誤的方式，但也有少數紅旗在你的代碼我跳了出來。

1. 使用goto跳是不好的做法。它會影響你的程序流程並迫使你分離不應該分開的任務。您在</div>丟失時標記了代碼段「// NON CLOSED」，這是否有任何目的？你怎麼知道goto部分是可靠的？

2. 當你echo像<div class="col">，不逃避雙引號（如在\「爲每」字符），也可以是有問題的。您的代碼可能會在PHP端或HTML端受到損壞或錯誤解釋。

像其他人一樣，PHP的使用可能在這裏矯枉過正。除了發送JSON外，其餘的都可以通過JavaScript處理。